Skip intermittently failing tests #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NewRelic::Agent::PipeChannelManagerTest has two cases failing on Ruby 2.5.9 and Rails 6.0/6.1: #test_listener_merges_error_events, #test_listener_merges_error_traces These tests started failing after PR#1969 was merged: #1969 The tests are now skipped in the specific conditions where they intermittently fail
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
approved these changes
May 1, 2023
| skip if RUBY_VERSION == '2.5.9' && | ||
| defined?(Rails::VERSION::STRING) && | ||
| # version string starts with 6.0 or 6.1 | ||
| Rails::VERSION::STRING =~ /\A6\.(0|1)/ |
There was a problem hiding this comment.
Given that there won't be a Rails 6.2, I think checking for Rails::VERSION::MAJOR and then doing Rails::VERSION::MAJOR == 6 would suffice. Given the context (test code only) there's no need to change it though.
There was a problem hiding this comment.
Thanks for this suggestion. I thought about that too, even though it seems unlikely/unprecedented 6.2 would ever come out, I figured it might be better to specify.
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NewRelic::Agent::PipeChannelManagerTest has two cases failing on Ruby 2.5.9 and Rails 6.0/6.1:
#test_listener_merges_error_events, #test_listener_merges_error_traces
These tests started failing after PR#1969 was merged: #1969
The tests are now skipped in the specific conditions where they intermittently fail
This was tested locally using Ruby 2.5.9 and rails52 (where they should not be skipped), rails60, and rails61.